1998-04-05 23:44:12 +00:00
|
|
|
Things to do to hash.c:
|
1998-04-05 23:43:58 +00:00
|
|
|
|
|
|
|
|
Always use curly braces around statements in if/else/while/do/etc.
|
|
|
|
|
that span more than a line -- even around multiline simple statements
|
|
|
|
|
or single-line simple statements preceded by a comment line.
|
|
|
|
|
|
|
|
|
|
Never have lines longer than 80 chars.
|
|
|
|
|
|
|
|
|
|
Remove ^L characters. We don't want/need such crutches.
|
|
|
|
|
Get a good (smart) pagination filter. I have one (a perl script)
|
|
|
|
|
that usually does a decent job for me -- I called it something
|
|
|
|
|
like stdc-print and think I sent you an early verison.
|
|
|
|
|
|
|
|
|
|
I don't like the name `cursor'. I much prefer short names
|
|
|
|
|
like `p' for index variables. I doubt I'll change all of them,
|
|
|
|
|
but thought you should know why some will probably end up changing.
|
1998-04-06 00:26:54 +00:00
|
|
|
|
|
|
|
|
#define USE_OBSTACK somewhere
|
|
|
|
|
|
|
|
|
|
Fix this comment. Depending on system and application...
|
|
|
|
|
Mention fragmentation.
|
|
|
|
|
+#if USE_OBSTACK
|
|
|
|
|
+ /* Whenever obstacks are used, it is possible to allocate all overflowed
|
|
|
|
|
+ entries into a single stack, so they all can be freed in a single
|
|
|
|
|
+ operation. It is not clear if the speedup is worth the trouble. */
|
|
|
|
|
+ struct obstack entry_stack;
|
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
assert (bucket_limit - bucket == n_buckets) ?
|
1998-05-04 00:28:35 +00:00
|
|
|
|
|
|
|
|
remove.c: s/done/successful or ok
|
