CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-20 18:56:39 +02:00
Code Issues Projects Releases Wiki Activity

split: plug nominal leaks

Browse Source 
* src/split.c (lines_rr) [IF_LINT]: Plug a harmless leak.
(main) [IF_LINT]: Free a usually-small (~70KB) buffer
just before exit, mainly to take this off the radar of
leak-detecting tools.

Improved-by: Pádraig Brady.
This commit is contained in:
Jim Meyering
2012-08-02 19:31:36 +02:00
parent e11a2cf319
commit 4abec7ef9a
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/split.c
View File

@@ -1044,6 +1044,7 @@ no_filters:
files[i_file].ofd = OFD_APPEND;
}
}
IF_LINT (free (files));
}
#define FAIL_ONLY_ONE_WAY() \
@@ -1075,7 +1076,6 @@ main (int argc, char **argv)
{
enum Split_type split_type = type_undef;
size_t in_blk_size = 0; /* optimal block size of input file device */
char *buf; /* file i/o buffer */
size_t page_size = getpagesize ();
uintmax_t k_units = 0;
uintmax_t n_units;
@@ -1382,7 +1382,8 @@ main (int argc, char **argv)
file_size = MAX (file_size, n_units);
}
buf = ptr_align (xmalloc (in_blk_size + 1 + page_size - 1), page_size);
void *b = xmalloc (in_blk_size + 1 + page_size - 1);
char *buf = ptr_align (b, page_size);
/* When filtering, closure of one pipe must not terminate the process,
as there may still be other streams expecting input from us. */
@@ -1432,6 +1433,8 @@ main (int argc, char **argv)
abort ();
}
IF_LINT (free (b));
if (close (STDIN_FILENO) != 0)
error (EXIT_FAILURE, errno, "%s", infile);
closeout (NULL, output_desc, filter_pid, outfile);