CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-08-05 08:10:15 +02:00
Code Issues Projects Releases Wiki Activity

maint: always free a buffer, to avoid even semblance of a leak

Browse Source 
* src/tac.c (main): Free the input buffer in most cases.
This commit is contained in:
Jim Meyering
2010-01-04 16:49:30 +01:00
parent dc0f5eb6a0
commit be6c13e7e0
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tac.c
+6 -1
View File
@@ -633,6 +633,7 @@ main (int argc, char **argv)
if (! (read_size < half_buffer_size && half_buffer_size < G_buffer_size)) if (! (read_size < half_buffer_size && half_buffer_size < G_buffer_size))
xalloc_die (); xalloc_die ();
G_buffer = xmalloc (G_buffer_size); G_buffer = xmalloc (G_buffer_size);
void *buf = G_buffer;
if (sentinel_length) if (sentinel_length)
{ {
strcpy (G_buffer, separator); strcpy (G_buffer, separator);
@@ -661,6 +662,10 @@ main (int argc, char **argv)
output ((char *) NULL, (char *) NULL); output ((char *) NULL, (char *) NULL);
if (have_read_stdin && close (STDIN_FILENO) < 0) if (have_read_stdin && close (STDIN_FILENO) < 0)
error (EXIT_FAILURE, errno, "-"); {
error (0, errno, "-");
ok = false;
}
free (buf);
exit (ok ? EXIT_SUCCESS : EXIT_FAILURE); exit (ok ? EXIT_SUCCESS : EXIT_FAILURE);
} }