CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-20 18:56:39 +02:00
Code Issues Projects Releases Wiki Activity

ls: always print "?" for allocated size of a dereferenced dangling symlink

Browse Source 
Previously for `ls -Ls` (but not `ls -Lsl`), we referenced
the st_blocks returned from the previous failed stat() call.
This undefined value was seen to be 0 for dangling symlinks at least.
* src/ls.c (print_file_name_and_frills, length_of_file_name_and_frills):
Don't use st_blocks if the previous stat() failed
* tests/ls/dangle: Add a test case
* NEWS: Mention the fix, and roll up related items into a single entry.
This commit is contained in:
Pádraig Brady
2009-09-29 15:43:01 +01:00
parent ce1069c215
commit d4c7114bce
3 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/ls/dangle
View File

@@ -28,7 +28,8 @@ mkdir -p dir/sub || framework_failure
ln -s dir slink-to-dir || framework_failure
mkdir d || framework_failure
ln -s no-such d/dangle || framework_failure
echo '? dangle' > subdir_exp || framework_failure
printf '? dangle\n' > subdir_Li_exp || framework_failure
printf 'total 0\n? dangle\n' > subdir_Ls_exp || framework_failure
fail=0
@@ -56,6 +57,11 @@ compare out exp || fail=1
# Ensure that ls -Li prints "?" as the inode of a dangling symlink.
rm -f out
ls -Li d > out 2>/dev/null && fail=1
compare out subdir_exp || fail=1
compare out subdir_Li_exp || fail=1
# Ensure that ls -Ls prints "?" as the allocation of a dangling symlink.
rm -f out
ls -Ls d > out 2>/dev/null && fail=1
compare out subdir_Ls_exp || fail=1
Exit $fail