1
0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-21 03:12:48 +02:00

tail: flush initial output before possibly blocking

* src/tail.c (main): Flush any output from tail_file,
before calling tail_forever_inotify, which can block.
* tests/tail-2/flush-initial: New file.  Test for the bug.
* tests/Makefile.am (TESTS): Add tail-2/flush-initial.
* NEWS (Bug fixes): Mention it.
This bug was introduced in coreutils-7.5 via commit ae494d4b,
2009-06-02, "tail: use inotify if it is available".
This commit is contained in:
Jim Meyering
2009-09-06 09:39:31 +02:00
parent af054f80b2
commit d54376db68
4 changed files with 53 additions and 1 deletions

View File

@@ -427,6 +427,7 @@ TESTS = \
rmdir/t-slash \
tail-2/assert-2 \
tail-2/big-4gb \
tail-2/flush-initial \
tail-2/proc-ksyms \
tail-2/start-middle \
touch/dangling-symlink \

41
tests/tail-2/flush-initial Executable file
View File

@@ -0,0 +1,41 @@
#!/bin/sh
# inotify-based tail -f didn't flush its initial output before blocking
# Copyright (C) 2009 Free Software Foundation, Inc.
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
if test "$VERBOSE" = yes; then
set -x
tail --version
fi
. $srcdir/test-lib.sh
fail=0
echo line > in || fail=1
stdbuf --output=1K tail -f in > out &
tail_pid=$!
# Wait for the backgrounded `tail' to start.
while :; do
env kill -0 $tail_pid && break
sleep .1
done
test -s out || fail=1
kill $tail_pid
Exit $fail