mirror of
git://git.sv.gnu.org/coreutils.git
synced 2026-04-20 18:56:39 +02:00
e43d30eab3
Exempt init.sh because it runs before we're assured to have a
shell that groks $(...). Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run. Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...). Do that by running this command:
git grep -l '`.*`' tests \
| grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
| xargs perl -pi -e 's/`(.*?)`/\$($1)/g'
One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
- expected_perms=$(eval 'echo \$expected_'$dest)
+ expected_perms=$(eval 'echo $expected_'$dest)
Another was to make these required quoting adjustments:
diff --git a/tests/misc/stty b/tests/misc/stty
...
- rev=$(eval echo "\\\$REV_$opt")
+ rev=$(eval echo "\$REV_$opt")
...
- rev1=$(eval echo "\\\$REV_$opt1")
- rev2=$(eval echo "\\\$REV_$opt2")
+ rev1=$(eval echo "\$REV_$opt1")
+ rev2=$(eval echo "\$REV_$opt2")
Also, transform two files that were needlessly excluded above:
(both use perl, but are mostly bourne shell)
perl -pi -e 's/`(.*?)`/\$($1)/g' \
tests/du/long-from-unreadable tests/init.cfg
65 lines
1.8 KiB
Bash
Executable File
65 lines
1.8 KiB
Bash
Executable File
#!/bin/sh
|
|
# Make sure cp -pR --parents isn't too generous with parent permissions.
|
|
|
|
# Copyright (C) 2006-2012 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/init.sh"; path_prepend_ ../src
|
|
print_ver_ cp
|
|
|
|
# cp -p gives ENOTSUP on NFS on Linux 2.6.9 at least
|
|
require_local_dir_
|
|
|
|
umask 002
|
|
mkdir mode ownership d || framework_failure_
|
|
chmod g+s d 2>/dev/null # The cp test is valid either way.
|
|
|
|
|
|
for attr in mode ownership
|
|
do
|
|
mkfifo_or_skip_ $attr/fifo
|
|
|
|
# Copy a fifo's contents. That way, we can examine d/$attr's
|
|
# state while cp is running.
|
|
cp --preserve=$attr -R --copy-contents --parents $attr d &
|
|
cp_pid=$!
|
|
|
|
(
|
|
# Now 'cp' is reading the fifo.
|
|
# Check the permissions of the temporary destination
|
|
# directory that 'cp' has made.
|
|
ls -ld d/$attr >d/$attr.ls
|
|
|
|
# Close the fifo so that "cp" can continue. But output first,
|
|
# before exiting, otherwise some shells would optimize away the file
|
|
# descriptor that holds the fifo open.
|
|
echo foo
|
|
) >$attr/fifo
|
|
|
|
ls_output=$(cat d/$attr.ls) || fail=1
|
|
case $attr,$ls_output in
|
|
ownership,d???--[-S]--[-S]* | \
|
|
mode,d????-??-?* | \
|
|
mode,d??[-x]?w[-x]?-[-x]* )
|
|
;;
|
|
*)
|
|
fail=1;;
|
|
esac
|
|
|
|
wait $cp_pid || fail=1
|
|
done
|
|
|
|
Exit $fail
|