mirror of
git://git.sv.gnu.org/coreutils.git
synced 2026-04-19 10:15:48 +02:00
58cff8a009
Many tests use `program ... && fail=1` to ensure expected error situations are indicated. However that would mask an unexpected exit (like a crash). Therefore explicitly check the expected exit code. Note where error messages are also verified, the extra protection is not added. * tests/init.sh (returns_): A new helper function to check the return code of a command, and used throughout the tests. * cfg.mk (sc_prohibit_and_fail_1): Add a syntax check to avoid new instances of this issue.
47 lines
1.8 KiB
Bash
Executable File
47 lines
1.8 KiB
Bash
Executable File
#!/bin/sh
|
|
# Ensure that stty diagnoses invalid inputs, rather than silently misbehaving.
|
|
|
|
# Copyright (C) 2007-2015 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src
|
|
print_ver_ stty
|
|
require_controlling_input_terminal_
|
|
trap '' TTOU # Ignore SIGTTOU
|
|
|
|
|
|
saved_state=$(stty -g) || fail=1
|
|
stty $saved_state || fail=1
|
|
|
|
# Before coreutils-6.9.90, if stty were given an argument with 35 colons
|
|
# separating 36 hexadecimal strings, stty would fail to diagnose as invalid
|
|
# any number that was out of range as long as sscanf happened to
|
|
# overflow/wrap it back into the range of the corresponding type (either
|
|
# tcflag_t or cc_t).
|
|
|
|
# For each of the following, with coreutils-6.9 and earlier,
|
|
# stty would fail to diagnose the error on at least Solaris 10.
|
|
hex_2_64=10000000000000000
|
|
returns_ 1 stty $(echo $saved_state |sed 's/^[^:]*:/'$hex_2_64:/) \
|
|
2>/dev/null || fail=1
|
|
returns_ 1 stty $(echo $saved_state |sed 's/:[0-9a-f]*$/:'$hex_2_64/) \
|
|
2>/dev/null || fail=1
|
|
|
|
# Just in case either of the above mistakenly succeeds (and changes
|
|
# the state of our tty), try to restore the initial state.
|
|
stty $saved_state || fail=1
|
|
|
|
Exit $fail
|