mirror of
git://git.sv.gnu.org/coreutils.git
synced 2026-04-06 04:03:48 +02:00
e43d30eab3
Exempt init.sh because it runs before we're assured to have a
shell that groks $(...). Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run. Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...). Do that by running this command:
git grep -l '`.*`' tests \
| grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
| xargs perl -pi -e 's/`(.*?)`/\$($1)/g'
One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
- expected_perms=$(eval 'echo \$expected_'$dest)
+ expected_perms=$(eval 'echo $expected_'$dest)
Another was to make these required quoting adjustments:
diff --git a/tests/misc/stty b/tests/misc/stty
...
- rev=$(eval echo "\\\$REV_$opt")
+ rev=$(eval echo "\$REV_$opt")
...
- rev1=$(eval echo "\\\$REV_$opt1")
- rev2=$(eval echo "\\\$REV_$opt2")
+ rev1=$(eval echo "\$REV_$opt1")
+ rev2=$(eval echo "\$REV_$opt2")
Also, transform two files that were needlessly excluded above:
(both use perl, but are mostly bourne shell)
perl -pi -e 's/`(.*?)`/\$($1)/g' \
tests/du/long-from-unreadable tests/init.cfg
47 lines
1.4 KiB
Bash
Executable File
47 lines
1.4 KiB
Bash
Executable File
#!/bin/sh
|
|
# Make sure chmod mode arguments of the form A=B work properly.
|
|
# Before fileutils-4.1.2, some of them didn't.
|
|
# Also, before coreutils-5.3.1, =[ugo] sometimes didn't work.
|
|
|
|
# Copyright (C) 2001-2012 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/init.sh"; path_prepend_ ../src
|
|
print_ver_ chmod
|
|
|
|
touch f || framework_failure_
|
|
|
|
|
|
expected_u=-rwx------
|
|
expected_g=----rwx---
|
|
expected_o=-------rwx
|
|
|
|
for src in u g o; do
|
|
for dest in u g o; do
|
|
test $dest = $src && continue
|
|
chmod a=,$src=rwx,$dest=$src,$src= f || fail=1
|
|
actual_perms=$(ls -l f|cut -b-10)
|
|
expected_perms=$(eval 'echo $expected_'$dest)
|
|
test "$actual_perms" = "$expected_perms" || fail=1
|
|
done
|
|
done
|
|
|
|
umask 027
|
|
chmod a=,u=rwx,=u f || fail=1
|
|
actual_perms=$(ls -l f|cut -b-10)
|
|
test "$actual_perms" = "-rwxr-x---" || fail=1
|
|
|
|
Exit $fail
|