mirror of
git://git.sv.gnu.org/coreutils.git
synced 2026-04-09 21:53:55 +02:00
e43d30eab3
Exempt init.sh because it runs before we're assured to have a
shell that groks $(...). Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run. Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...). Do that by running this command:
git grep -l '`.*`' tests \
| grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
| xargs perl -pi -e 's/`(.*?)`/\$($1)/g'
One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
- expected_perms=$(eval 'echo \$expected_'$dest)
+ expected_perms=$(eval 'echo $expected_'$dest)
Another was to make these required quoting adjustments:
diff --git a/tests/misc/stty b/tests/misc/stty
...
- rev=$(eval echo "\\\$REV_$opt")
+ rev=$(eval echo "\$REV_$opt")
...
- rev1=$(eval echo "\\\$REV_$opt1")
- rev2=$(eval echo "\\\$REV_$opt2")
+ rev1=$(eval echo "\$REV_$opt1")
+ rev2=$(eval echo "\$REV_$opt2")
Also, transform two files that were needlessly excluded above:
(both use perl, but are mostly bourne shell)
perl -pi -e 's/`(.*?)`/\$($1)/g' \
tests/du/long-from-unreadable tests/init.cfg
51 lines
1.5 KiB
Bash
Executable File
51 lines
1.5 KiB
Bash
Executable File
#!/bin/sh
|
|
# make sure 'cp -p' preserves special bits
|
|
# This works only when run as root.
|
|
|
|
# Copyright (C) 2000-2012 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This test would fail due to a bug introduced in 4.0y.
|
|
# The bug was fixed in 4.0z.
|
|
|
|
. "${srcdir=.}/init.sh"; path_prepend_ ../src
|
|
print_ver_ cp
|
|
require_root_
|
|
|
|
touch a b c || framework_failure_
|
|
chmod u+sx,go= a || framework_failure_
|
|
chmod u=rwx,g=sx,o= b || framework_failure_
|
|
chmod a=r,ug+sx c || framework_failure_
|
|
chown $NON_ROOT_USERNAME . || framework_failure_
|
|
chmod u=rwx,g=rx,o=rx . || framework_failure_
|
|
|
|
|
|
cp -p a a2 || fail=1
|
|
set _ $(ls -l a); shift; p1=$1
|
|
set _ $(ls -l a2); shift; p2=$1
|
|
test $p1 = $p2 || fail=1
|
|
|
|
cp -p b b2 || fail=1
|
|
set _ $(ls -l b); shift; p1=$1
|
|
set _ $(ls -l b2); shift; p2=$1
|
|
test $p1 = $p2 || fail=1
|
|
|
|
setuidgid $NON_ROOT_USERNAME env PATH="$PATH" cp -p c c2 || fail=1
|
|
set _ $(ls -l c); shift; p1=$1
|
|
set _ $(ls -l c2); shift; p2=$1
|
|
test $p1 = $p2 && fail=1
|
|
|
|
Exit $fail
|