mirror of
git://git.sv.gnu.org/coreutils.git
synced 2026-04-01 09:44:43 +02:00
e43d30eab3
Exempt init.sh because it runs before we're assured to have a
shell that groks $(...). Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run. Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...). Do that by running this command:
git grep -l '`.*`' tests \
| grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
| xargs perl -pi -e 's/`(.*?)`/\$($1)/g'
One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
- expected_perms=$(eval 'echo \$expected_'$dest)
+ expected_perms=$(eval 'echo $expected_'$dest)
Another was to make these required quoting adjustments:
diff --git a/tests/misc/stty b/tests/misc/stty
...
- rev=$(eval echo "\\\$REV_$opt")
+ rev=$(eval echo "\$REV_$opt")
...
- rev1=$(eval echo "\\\$REV_$opt1")
- rev2=$(eval echo "\\\$REV_$opt2")
+ rev1=$(eval echo "\$REV_$opt1")
+ rev2=$(eval echo "\$REV_$opt2")
Also, transform two files that were needlessly excluded above:
(both use perl, but are mostly bourne shell)
perl -pi -e 's/`(.*?)`/\$($1)/g' \
tests/du/long-from-unreadable tests/init.cfg
46 lines
1.5 KiB
Bash
Executable File
46 lines
1.5 KiB
Bash
Executable File
#!/bin/sh
|
|
# ensure that mv doesn't first unlink a multi-hard-linked destination
|
|
|
|
# Copyright (C) 2008-2012 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/init.sh"; path_prepend_ ../src
|
|
print_ver_ mv
|
|
require_strace_ unlink
|
|
|
|
# Before the fix, mv would unnecessarily unlink the destination symlink:
|
|
# $ rm -f a b b2; touch a b; ln b b2; strace -e unlink /p/bin/mv a b
|
|
# unlink("b") = 0
|
|
#
|
|
# With the fix, it doesn't call unlink:
|
|
# $ rm -f a b b2; touch a b; ln b b2; strace -e unlink ./mv a b
|
|
# $
|
|
|
|
touch a b || framework_failure_
|
|
ln b b2 || framework_failure_
|
|
|
|
|
|
strace -qe unlink mv a b > out 2>&1 || fail=1
|
|
$EGREP 'unlink.*"b"' out && fail=1
|
|
|
|
# Ensure that the source, "a", is gone.
|
|
ls -dl a > /dev/null 2>&1 && fail=1
|
|
|
|
# Ensure that the destination, "b", has link count 1.
|
|
n_links=$(stat --printf=%h b) || fail=1
|
|
test "$n_links" = 1 || fail=1
|
|
|
|
Exit $fail
|