mirror of
git://git.sv.gnu.org/coreutils.git
synced 2026-03-28 15:54:58 +02:00
Exempt init.sh because it runs before we're assured to have a
shell that groks $(...). Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run. Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...). Do that by running this command:
git grep -l '`.*`' tests \
| grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
| xargs perl -pi -e 's/`(.*?)`/\$($1)/g'
One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
- expected_perms=$(eval 'echo \$expected_'$dest)
+ expected_perms=$(eval 'echo $expected_'$dest)
Another was to make these required quoting adjustments:
diff --git a/tests/misc/stty b/tests/misc/stty
...
- rev=$(eval echo "\\\$REV_$opt")
+ rev=$(eval echo "\$REV_$opt")
...
- rev1=$(eval echo "\\\$REV_$opt1")
- rev2=$(eval echo "\\\$REV_$opt2")
+ rev1=$(eval echo "\$REV_$opt1")
+ rev2=$(eval echo "\$REV_$opt2")
Also, transform two files that were needlessly excluded above:
(both use perl, but are mostly bourne shell)
perl -pi -e 's/`(.*?)`/\$($1)/g' \
tests/du/long-from-unreadable tests/init.cfg
53 lines
1.7 KiB
Bash
Executable File
53 lines
1.7 KiB
Bash
Executable File
#!/bin/sh
|
|
# Ensure that rm -f nonexistent-file-on-read-only-fs succeeds.
|
|
|
|
# Copyright (C) 2009-2012 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/init.sh"; path_prepend_ ../src
|
|
print_ver_ rm
|
|
require_root_
|
|
|
|
cwd=$(pwd)
|
|
cleanup_() { cd /; umount "$cwd/mnt"; }
|
|
|
|
skip=0
|
|
# Create a file system, then mount it.
|
|
dd if=/dev/zero of=blob bs=8192 count=200 > /dev/null 2>&1 \
|
|
|| skip=1
|
|
mkdir mnt || skip=1
|
|
mkfs -t ext2 -F blob \
|
|
|| skip_ "failed to create ext2 file system"
|
|
|
|
mount -oloop blob mnt || skip=1
|
|
echo test > mnt/f || skip=1
|
|
test -s mnt/f || skip=1
|
|
mount -o remount,loop,ro mnt || skip=1
|
|
|
|
test $skip = 1 \
|
|
&& skip_ "insufficient mount/ext2 support"
|
|
|
|
# Applying rm -f to a nonexistent file on a read-only file system must succeed.
|
|
rm -f mnt/no-such > out 2>&1 || fail=1
|
|
# It must produce no diagnostic.
|
|
test -s out && fail=1
|
|
|
|
# However, trying to remove an existing file must fail.
|
|
rm -f mnt/f > out 2>&1 && fail=1
|
|
# with a diagnostic.
|
|
test -s out || fail=1
|
|
|
|
Exit $fail
|