1
0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-20 18:56:39 +02:00
Files
coreutils/tests/misc/cksum-a.sh
Pádraig Brady a42a039132 cksum: use more exact selection of digest algorithms
Use more constrained argument matching
to improve forward compatibility and robustness.

For example it's better that `cksum -a sha3` is _not_
equivalent to `cksum -a sha386`, so that a user
specifying `-a sha3` on an older cksum would not be surprised.

Also argmatch() is used when parsing tags from lines like:
SHA3 (filename) = abcedf....
so it's more robust that older cksum instances to fail
earlier in the parsing process, when parsing output from
possible future cksum implementations that might support SHA3.

* src/digest.c (algorithm_from_tag): Use argmatch_exact()
to ensure we don't match abbreviated algorithms.
(main): Likewise.
* tests/misc/cksum-a.sh: Add a test case.
2022-01-30 23:13:52 +00:00

57 lines
1.6 KiB
Bash
Executable File

#!/bin/sh
# Validate cksum --algorithm operation
# Copyright (C) 2021-2022 Free Software Foundation, Inc.
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src
print_ver_ cksum
cat > input_options <<\EOF || framework_failure_
bsd sum -r
sysv sum -s
crc cksum
md5 md5sum -t
sha1 sha1sum -t
sha224 sha224sum -t
sha256 sha256sum -t
sha384 sha384sum -t
sha512 sha512sum -t
blake2b b2sum -t
EOF
while read algo prog; do
$prog /dev/null >> out || continue
cksum --untagged --algorithm=$algo /dev/null > out-c || fail=1
case "$algo" in
bsd) ;;
sysv) ;;
crc) ;;
*) cksum --check --algorithm=$algo out-c || fail=1 ;;
esac
cat out-c >> out-a || framework_failure_
done < input_options
compare out out-a || fail=1
# Ensure --check not allowed with older (non tagged) algorithms
returns_ 1 cksum -a bsd --check </dev/null || fail=1
# Ensure abbreviations not supported for algorithm selection
returns_ 1 cksum -a sha22 </dev/null || fail=1
Exit $fail