1
0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-02-24 16:15:23 +02:00
Files
coreutils/src/nice.c
Collin Funk fc93a44bbe nice: clamp the niceness correctly on GNU/Hurd
* NEWS: Mention the bug fix.
* src/nice.c (MIN_ADJUSTMENT): Set to 0 on the Hurd with glibc ≤ 2.42.
(MAX_ADJUSTMENT): Set to (2 * NZERO - 2) on the Hurd with glibc ≤ 2.42.
(main): Clamp the niceness to be greater or equal to MIN_ADJUSTMENT and
less than or equal to MAX_ADJUSTMENT.
* tests/nice/nice.sh: Add some tests for the Hurd's ranges.
2025-11-09 18:48:34 -08:00

256 lines
7.2 KiB
C

/* nice -- run a program with modified niceness
Copyright (C) 1990-2025 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>. */
/* David MacKenzie <djm@gnu.ai.mit.edu> */
#include <config.h>
#include <stdio.h>
#include <getopt.h>
#include <sys/types.h>
#include "system.h"
#if ! HAVE_NICE
/* Include this after "system.h" so we're sure to have definitions
(from time.h or sys/time.h) required for e.g. the ru_utime member. */
# include <sys/resource.h>
#endif
#include "c-ctype.h"
#include "quote.h"
#include "xstrtol.h"
/* The official name of this program (e.g., no 'g' prefix). */
#define PROGRAM_NAME "nice"
#define AUTHORS proper_name ("David MacKenzie")
#if HAVE_NICE
# define GET_NICENESS() nice (0)
#else
# define GET_NICENESS() getpriority (PRIO_PROCESS, 0)
#endif
#ifndef NZERO
# define NZERO 20
#endif
/* This is required for Darwin Kernel Version 7.7.0. */
#if NZERO == 0
# undef NZERO
# define NZERO 20
#endif
static struct option const longopts[] =
{
{"adjustment", required_argument, nullptr, 'n'},
{GETOPT_HELP_OPTION_DECL},
{GETOPT_VERSION_OPTION_DECL},
{nullptr, 0, nullptr, 0}
};
void
usage (int status)
{
if (status != EXIT_SUCCESS)
emit_try_help ();
else
{
printf (_("Usage: %s [OPTION] [COMMAND [ARG]...]\n"), program_name);
printf (_("\
Run COMMAND with an adjusted niceness, which affects process scheduling.\n\
With no COMMAND, print the current niceness. Niceness values range from\n\
%d (most favorable to the process) to %d (least favorable to the process).\n\
"),
- NZERO, NZERO - 1);
emit_mandatory_arg_note ();
fputs (_("\
-n, --adjustment=N add integer N to the niceness (default 10)\n\
"), stdout);
fputs (HELP_OPTION_DESCRIPTION, stdout);
fputs (VERSION_OPTION_DESCRIPTION, stdout);
printf (USAGE_BUILTIN_WARNING, PROGRAM_NAME);
emit_exec_status (PROGRAM_NAME);
emit_ancillary_info (PROGRAM_NAME);
}
exit (status);
}
static bool
perm_related_errno (int err)
{
return err == EACCES || err == EPERM;
}
int
main (int argc, char **argv)
{
int current_niceness;
int adjustment = 10;
char const *adjustment_given = nullptr;
bool ok;
int i;
initialize_main (&argc, &argv);
set_program_name (argv[0]);
setlocale (LC_ALL, "");
bindtextdomain (PACKAGE, LOCALEDIR);
textdomain (PACKAGE);
initialize_exit_failure (EXIT_CANCELED);
atexit (close_stdout);
for (i = 1; i < argc; /* empty */)
{
char const *s = argv[i];
if (s[0] == '-' && c_isdigit (s[1 + (s[1] == '-' || s[1] == '+')]))
{
adjustment_given = s + 1;
++i;
}
else
{
int c;
int fake_argc = argc - (i - 1);
char **fake_argv = argv + (i - 1);
/* Ensure that any getopt diagnostics use the right name. */
fake_argv[0] = argv[0];
/* Initialize getopt_long's internal state. */
optind = 0;
c = getopt_long (fake_argc, fake_argv, "+n:", longopts, nullptr);
i += optind - 1;
switch (c)
{
case 'n':
adjustment_given = optarg;
break;
case -1:
break;
case_GETOPT_HELP_CHAR;
case_GETOPT_VERSION_CHAR (PROGRAM_NAME, AUTHORS);
default:
usage (EXIT_CANCELED);
break;
}
if (c == -1)
break;
}
}
if (adjustment_given)
{
/* If the requested adjustment is outside the valid range,
silently bring it to just within range; this mimics what
"setpriority" and "nice" do. */
#if (defined __gnu_hurd__ \
&& (__GLIBC__ < 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ < 43)))
/* GNU/Hurd's nice(2) only supported 0 to (2 * NZERO - 2) niceness
until glibc 2.43. */
enum { MIN_ADJUSTMENT = 0, MAX_ADJUSTMENT = 2 * NZERO - 2 };
#else
enum { MIN_ADJUSTMENT = 1 - 2 * NZERO, MAX_ADJUSTMENT = 2 * NZERO - 1 };
#endif
long int tmp;
if (LONGINT_OVERFLOW < xstrtol (adjustment_given, nullptr, 10, &tmp, ""))
error (EXIT_CANCELED, 0, _("invalid adjustment %s"),
quote (adjustment_given));
#if (defined __gnu_hurd__ \
&& (__GLIBC__ < 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ < 43)))
/* GNU/Hurd's nice(2) also did not clamp the new niceness into the
supported range until glibc 2.43.
See <https://sourceware.org/PR33614>. */
errno = 0;
current_niceness = GET_NICENESS ();
if (current_niceness == -1 && errno != 0)
error (EXIT_CANCELED, errno, _("cannot get niceness"));
if (tmp < 0)
{
int sum;
if (ckd_add (&sum, current_niceness, tmp) || sum < MIN_ADJUSTMENT)
adjustment = MIN_ADJUSTMENT - current_niceness;
else
adjustment = tmp;
}
else
{
int sum;
if (ckd_add (&sum, current_niceness, tmp) || MAX_ADJUSTMENT < sum)
adjustment = MAX_ADJUSTMENT - current_niceness;
else
adjustment = tmp;
}
#else
adjustment = MAX (MIN_ADJUSTMENT, MIN (tmp, MAX_ADJUSTMENT));
#endif
}
if (i == argc)
{
if (adjustment_given)
{
error (0, 0, _("a command must be given with an adjustment"));
usage (EXIT_CANCELED);
}
/* No command given; print the niceness. */
errno = 0;
current_niceness = GET_NICENESS ();
if (current_niceness == -1 && errno != 0)
error (EXIT_CANCELED, errno, _("cannot get niceness"));
printf ("%d\n", current_niceness);
return EXIT_SUCCESS;
}
errno = 0;
#if HAVE_NICE
ok = (nice (adjustment) != -1 || errno == 0);
#else
current_niceness = GET_NICENESS ();
if (current_niceness == -1 && errno != 0)
error (EXIT_CANCELED, errno, _("cannot get niceness"));
ok = (setpriority (PRIO_PROCESS, 0, current_niceness + adjustment) == 0);
#endif
if (!ok)
{
error (perm_related_errno (errno) ? 0
: EXIT_CANCELED, errno, _("cannot set niceness"));
/* error() flushes stderr, but does not check for write failure.
Normally, we would catch this via our atexit() hook of
close_stdout, but execvp() gets in the way. If stderr
encountered a write failure, there is no need to try calling
error() again. */
if (ferror (stderr))
return EXIT_CANCELED;
}
execvp (argv[i], &argv[i]);
int exit_status = errno == ENOENT ? EXIT_ENOENT : EXIT_CANNOT_INVOKE;
error (0, errno, "%s", quote (argv[i]));
return exit_status;
}