Commit Graph

58 Commits

Author SHA1 Message Date
Alexander Naumov
277f4a36ac 'userbits' address out of bounce fix
We pass (1, 0) to calloc().
The ACLBYTE macro will return &NULL[(0 + 1) >> 3] equals 0.

On some systems (including OpenBSD) this will return
a zero sized object: a unique pointer that points to
unaccessable memory. This is permitted by the standards.
2024-06-07 14:06:15 +02:00
Chris Meyering
9bf0a785ca build: acls.c: mark unused parameters
* src/acls.c (DoSu): avoid four unused-variable warnings
2020-02-02 00:39:44 +01:00
Chris Meyering
33d9a92d04 cleanup: acls.c: move unused variables into #if-0 block
* src/acls.c (DoSu): avoid two unused-variable warnings
2020-02-02 00:39:29 +01:00
Chris Meyering
23f450eef0 build: cast NULL to (char *) to prevent GCC 10 warning
* src/acls.c (GrowBitfield): replace NULL by (char *)NULL.
This avoids the following warning:
acls.h:44:35: warning: dereferencing ‘void *’ pointer
2020-02-02 00:39:24 +01:00
Alexander Naumov
f66377f992 Using 'https' instead of 'http' 2019-11-09 14:40:37 +01:00
Amadeusz Sławiński
a462bc2858 use GetWindowByNumber(n) instead of wtab[n] 2018-04-11 21:42:16 +02:00
Amadeusz Sławiński
8be327be94 rename windows to mru_window and window->w_next to window->w_prev_mru
those variables are used to maintain most recently used list and I want
to reuse w_next to make proper list of windows instead of wtab

when we loop it doesn't make difference in which order we go, so we may
as well keep looping using mru list (and review later when we introduce
in order list)
2018-04-11 21:42:16 +02:00
Amadeusz Sławiński
60e19ab26e get rid of (sometype *)0 casts
using NULL makes it clear enough what's going on
2018-04-07 13:29:11 +02:00
Amadeusz Sławiński
81a2699fdd use NULL instead of 0 where applicable
found with sparse
warning: Using plain integer as NULL pointer
2018-04-06 00:18:33 +02:00
Amadeusz Sławiński
14b54b47bd reduce variables scope 2017-09-27 09:47:59 +02:00
Amadeusz Sławiński
a57f6c71ae u_plop, int len -> size_t len 2017-01-22 16:09:15 +01:00
Amadeusz Sławiński
f0109ebc3c further password cleanups
all towards handling things in one file (authenticate.c)
2016-06-18 15:08:28 +02:00
Amadeusz Sławiński
d2b1a04737 move config.h to top of includes
now that _GNU_SOURCE definition is in config.h we want to make sure that
all headers that are included know about it
2016-06-18 15:08:28 +02:00
Amadeusz Sławiński
94103f1c9a just enable syslog use 2016-06-18 15:08:28 +02:00
Simon Ruderich
263d9c6c8d make all header files self-contained and include it in the source file
Including the header in the source file guarantees matching signatures,
thus preventing subtle errors.

Self-contained headers document the required headers and makes using it
easier to use the header in new source files.
2016-02-07 17:57:37 +01:00
Amadeusz Sławiński
507647e26e Convert files to utf8 encoding so I can grep through them normally 2015-09-02 09:28:06 +02:00
Alexander Naumov
5c7fc6e760 fix: zmodem_fin() declaration + unused AclWinSwap() 2015-07-14 22:38:24 +02:00
Amadeusz Sławiński
b458d33267 Fix implicit declarations after merge 2015-07-04 19:59:07 +02:00
Amadeusz Sławiński
a73a91ea68 get rid of extern.h 2015-06-26 14:23:14 +02:00
Amadeusz Sławiński
97b2ec0ed4 move global variables declarations to corresponding headers 2015-06-26 12:30:55 +02:00
Amadeusz Sławiński
e40efef12c use Display type instead of struct display 2015-06-26 11:34:00 +02:00
Amadeusz Sławiński
7dd44046c9 use Window type instead of struct win 2015-06-26 10:52:01 +02:00
Amadeusz Sławiński
144836c3bb more header stuff
move forward declarations of functions from extern.h to their own header
files
fix inclusion option passed in Makefile
cosmetic stuff on some structs
2015-06-25 17:22:58 +02:00
Amadeusz Sławiński
272b68b2ec bye bye DEBUG 2015-06-25 17:05:31 +02:00
Amadeusz Sławiński
23d04da677 it's a Socket not Sock 2015-06-25 16:23:43 +02:00
Amadeusz Sławiński
906419527a Return -1 on failure like rest of functions 2015-06-25 16:22:13 +02:00
Amadeusz Sławiński
1c68e285e7 Comment acls.c code 2015-06-25 16:22:07 +02:00
Amadeusz Sławiński
983174c39d Code reformating
Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
2015-06-25 16:09:11 +02:00
Amadeusz Sławiński
87bccf5848 remove SHADOwpW stuff it doesn't seem to work 2015-06-25 15:55:22 +02:00
Amadeusz Sławiński
0dbcbb616b xrealloc returns void* and remove all *allocs casts 2015-06-25 15:54:32 +02:00
Amadeusz Sławiński
9c1722e63b Simplify debugging macros 2015-06-25 15:52:13 +02:00
Amadeusz Sławiński
9c3a98ba64 trailing whitespace removal 2015-06-25 15:52:13 +02:00
Amadeusz Sławiński
079db24a31 that's all? 2015-06-25 15:52:12 +02:00
Amadeusz Sławiński (amade)
4fe7d6b391 move extern's into one place 2015-06-25 14:44:15 +02:00
Amadeusz Sławiński (amade)
64256f70df unused variable r 2015-06-25 14:32:01 +02:00
Amadeusz Sławiński (amade)
2168239005 make most features as always built in from now on
removed #define SIMPLESCREEN and it's #defines
also removed #define DETACH and RXVT_SOC
all of this options are now default
2015-06-25 14:28:20 +02:00
Amadeusz Sławiński (amade)
1afd50e91c remove #if 0'ed code 2015-06-25 14:25:07 +02:00
Amadeusz Sławiński (amade)
2027a83047 rewrite functions definitions 2015-06-25 14:23:42 +02:00
Amadeusz Sławiński
b296029332 remove __P macro it's obsolete
inspired by a434e5d612
2015-06-25 14:19:28 +02:00
Amadeusz Sławiński
fe8103cccd allow for defining term and login length if needed
Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
2014-04-22 18:25:46 +02:00
Amadeusz Sławiński
b62e4ef097 Allow screen to run for users with long logins
username can have up to 32 characters

Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
2014-04-22 14:15:32 +02:00
Michael Schroeder
bc7e9d9e36 avoid compiler warning about crypt 2013-04-09 13:08:54 +02:00
Sadrul Habib Chowdhury
cbaa666d4f Guard against NULL returns from crypt().
crypt() can return NULL on an error. Make sure these nulls are
handled properly instead of crashing. The fix is thanks to a patch
from Lukáš Nykrýn <lnykryn@redhat.com>.
2012-09-14 23:40:23 -04:00
Sadrul Habib Chowdhury
9756ae6fb2 Get rid of compile-time warnings. 2010-02-12 16:38:38 -05:00
Sadrul Habib Chowdhury
f33e5cdecb Increase the max-window limit.
The limit can be increased using the 'maxwin' command. There is
still an upper-limit of 2048 windows.
2010-01-26 15:15:24 -05:00
Sadrul Habib Chowdhury
f04882c76d Copyright for 2009 2009-02-07 20:00:26 -05:00
Sadrul Habib Chowdhury
019910e9bd Update copyright messages some more. 2008-10-21 15:04:27 -04:00
Sadrul Habib Chowdhury
3322b5b496 Start converting to GPL v3+ (ref: ticket #23900)
I decided to leave the doc/ directory alone for the moment.
2008-10-13 14:12:02 -04:00
jnweiger
213136c085 screen-4.0.1 Sep 18 2003 2005-12-16 18:48:09 +00:00
jnweiger
b3e7420c1f old version screen-3.9.11 Feb 14 2002 2005-12-16 18:37:23 +00:00