Files
docker-machine/libmachine/drivers/rpc/client_driver.go
André Carvalho 02428eeb06 libmachine/drivers/rpc: close plugin binary even when driver server fails
With this commit the RPC client driver tries closing the plugin binary
even when closing the driver server fails. This prevents the driver
process from entering in <defunct> state when it failed before closing.

Signed-off-by: André Carvalho <asantostc@gmail.com>
2016-11-21 14:31:22 -02:00

368 lines
9.2 KiB
Go

package rpcdriver
import (
"fmt"
"net/rpc"
"sync"
"time"
"io"
"github.com/docker/machine/libmachine/drivers"
"github.com/docker/machine/libmachine/drivers/plugin/localbinary"
"github.com/docker/machine/libmachine/log"
"github.com/docker/machine/libmachine/mcnflag"
"github.com/docker/machine/libmachine/state"
"github.com/docker/machine/libmachine/version"
)
var (
heartbeatInterval = 5 * time.Second
)
type RPCClientDriverFactory interface {
NewRPCClientDriver(driverName string, rawDriver []byte) (*RPCClientDriver, error)
io.Closer
}
type DefaultRPCClientDriverFactory struct {
openedDrivers []*RPCClientDriver
openedDriversLock sync.Locker
}
func NewRPCClientDriverFactory() RPCClientDriverFactory {
return &DefaultRPCClientDriverFactory{
openedDrivers: []*RPCClientDriver{},
openedDriversLock: &sync.Mutex{},
}
}
type RPCClientDriver struct {
plugin localbinary.DriverPlugin
heartbeatDoneCh chan bool
Client *InternalClient
}
type RPCCall struct {
ServiceMethod string
Args interface{}
Reply interface{}
}
type InternalClient struct {
MachineName string
RPCClient *rpc.Client
rpcServiceName string
}
const (
RPCServiceNameV0 = `RpcServerDriver`
RPCServiceNameV1 = `RPCServerDriver`
HeartbeatMethod = `.Heartbeat`
GetVersionMethod = `.GetVersion`
CloseMethod = `.Close`
GetCreateFlagsMethod = `.GetCreateFlags`
SetConfigRawMethod = `.SetConfigRaw`
GetConfigRawMethod = `.GetConfigRaw`
DriverNameMethod = `.DriverName`
SetConfigFromFlagsMethod = `.SetConfigFromFlags`
GetURLMethod = `.GetURL`
GetMachineNameMethod = `.GetMachineName`
GetIPMethod = `.GetIP`
GetSSHHostnameMethod = `.GetSSHHostname`
GetSSHKeyPathMethod = `.GetSSHKeyPath`
GetSSHPortMethod = `.GetSSHPort`
GetSSHUsernameMethod = `.GetSSHUsername`
GetStateMethod = `.GetState`
PreCreateCheckMethod = `.PreCreateCheck`
CreateMethod = `.Create`
RemoveMethod = `.Remove`
StartMethod = `.Start`
StopMethod = `.Stop`
RestartMethod = `.Restart`
KillMethod = `.Kill`
UpgradeMethod = `.Upgrade`
)
func (ic *InternalClient) Call(serviceMethod string, args interface{}, reply interface{}) error {
if serviceMethod != HeartbeatMethod {
log.Debugf("(%s) Calling %+v", ic.MachineName, serviceMethod)
}
return ic.RPCClient.Call(ic.rpcServiceName+serviceMethod, args, reply)
}
func (ic *InternalClient) switchToV0() {
ic.rpcServiceName = RPCServiceNameV0
}
func NewInternalClient(rpcclient *rpc.Client) *InternalClient {
return &InternalClient{
RPCClient: rpcclient,
rpcServiceName: RPCServiceNameV1,
}
}
func (f *DefaultRPCClientDriverFactory) Close() error {
f.openedDriversLock.Lock()
defer f.openedDriversLock.Unlock()
for _, openedDriver := range f.openedDrivers {
if err := openedDriver.close(); err != nil {
// No need to display an error.
// There's nothing we can do and it doesn't add value to the user.
}
}
f.openedDrivers = []*RPCClientDriver{}
return nil
}
func (f *DefaultRPCClientDriverFactory) NewRPCClientDriver(driverName string, rawDriver []byte) (*RPCClientDriver, error) {
mcnName := ""
p, err := localbinary.NewPlugin(driverName)
if err != nil {
return nil, err
}
go func() {
if err := p.Serve(); err != nil {
// TODO: Is this best approach?
log.Warn(err)
return
}
}()
addr, err := p.Address()
if err != nil {
return nil, fmt.Errorf("Error attempting to get plugin server address for RPC: %s", err)
}
rpcclient, err := rpc.DialHTTP("tcp", addr)
if err != nil {
return nil, err
}
c := &RPCClientDriver{
Client: NewInternalClient(rpcclient),
heartbeatDoneCh: make(chan bool),
}
f.openedDriversLock.Lock()
f.openedDrivers = append(f.openedDrivers, c)
f.openedDriversLock.Unlock()
var serverVersion int
if err := c.Client.Call(GetVersionMethod, struct{}{}, &serverVersion); err != nil {
// this is the first call we make to the server. We try to play nice with old pre 0.5.1 client,
// by gracefully trying old RPCServiceName, we do this only once, and keep the result for future calls.
log.Debugf(err.Error())
log.Debugf("Client (%s) with %s does not work, re-attempting with %s", c.Client.MachineName, RPCServiceNameV1, RPCServiceNameV0)
c.Client.switchToV0()
if err := c.Client.Call(GetVersionMethod, struct{}{}, &serverVersion); err != nil {
return nil, err
}
}
if serverVersion != version.APIVersion {
return nil, fmt.Errorf("Driver binary uses an incompatible API version (%d)", serverVersion)
}
log.Debug("Using API Version ", serverVersion)
go func(c *RPCClientDriver) {
for {
select {
case <-c.heartbeatDoneCh:
return
case <-time.After(heartbeatInterval):
if err := c.Client.Call(HeartbeatMethod, struct{}{}, nil); err != nil {
log.Warnf("Wrapper Docker Machine process exiting due to closed plugin server (%s)", err)
if err := c.close(); err != nil {
log.Warn(err)
}
}
}
}
}(c)
if err := c.SetConfigRaw(rawDriver); err != nil {
return nil, err
}
mcnName = c.GetMachineName()
p.MachineName = mcnName
c.Client.MachineName = mcnName
c.plugin = p
return c, nil
}
func (c *RPCClientDriver) MarshalJSON() ([]byte, error) {
return c.GetConfigRaw()
}
func (c *RPCClientDriver) UnmarshalJSON(data []byte) error {
return c.SetConfigRaw(data)
}
func (c *RPCClientDriver) close() error {
c.heartbeatDoneCh <- true
close(c.heartbeatDoneCh)
log.Debug("Making call to close driver server")
if err := c.Client.Call(CloseMethod, struct{}{}, nil); err != nil {
log.Debugf("Failed to make call to close driver server: %s", err)
} else {
log.Debug("Successfully made call to close driver server")
}
log.Debug("Making call to close connection to plugin binary")
return c.plugin.Close()
}
// Helper method to make requests which take no arguments and return simply a
// string, e.g. "GetIP".
func (c *RPCClientDriver) rpcStringCall(method string) (string, error) {
var info string
if err := c.Client.Call(method, struct{}{}, &info); err != nil {
return "", err
}
return info, nil
}
func (c *RPCClientDriver) GetCreateFlags() []mcnflag.Flag {
var flags []mcnflag.Flag
if err := c.Client.Call(GetCreateFlagsMethod, struct{}{}, &flags); err != nil {
log.Warnf("Error attempting call to get create flags: %s", err)
}
return flags
}
func (c *RPCClientDriver) SetConfigRaw(data []byte) error {
return c.Client.Call(SetConfigRawMethod, data, nil)
}
func (c *RPCClientDriver) GetConfigRaw() ([]byte, error) {
var data []byte
if err := c.Client.Call(GetConfigRawMethod, struct{}{}, &data); err != nil {
return nil, err
}
return data, nil
}
// DriverName returns the name of the driver
func (c *RPCClientDriver) DriverName() string {
driverName, err := c.rpcStringCall(DriverNameMethod)
if err != nil {
log.Warnf("Error attempting call to get driver name: %s", err)
}
return driverName
}
func (c *RPCClientDriver) SetConfigFromFlags(flags drivers.DriverOptions) error {
return c.Client.Call(SetConfigFromFlagsMethod, &flags, nil)
}
func (c *RPCClientDriver) GetURL() (string, error) {
return c.rpcStringCall(GetURLMethod)
}
func (c *RPCClientDriver) GetMachineName() string {
name, err := c.rpcStringCall(GetMachineNameMethod)
if err != nil {
log.Warnf("Error attempting call to get machine name: %s", err)
}
return name
}
func (c *RPCClientDriver) GetIP() (string, error) {
return c.rpcStringCall(GetIPMethod)
}
func (c *RPCClientDriver) GetSSHHostname() (string, error) {
return c.rpcStringCall(GetSSHHostnameMethod)
}
// GetSSHKeyPath returns the key path
// TODO: This method doesn't even make sense to have with RPC.
func (c *RPCClientDriver) GetSSHKeyPath() string {
path, err := c.rpcStringCall(GetSSHKeyPathMethod)
if err != nil {
log.Warnf("Error attempting call to get SSH key path: %s", err)
}
return path
}
func (c *RPCClientDriver) GetSSHPort() (int, error) {
var port int
if err := c.Client.Call(GetSSHPortMethod, struct{}{}, &port); err != nil {
return 0, err
}
return port, nil
}
func (c *RPCClientDriver) GetSSHUsername() string {
username, err := c.rpcStringCall(GetSSHUsernameMethod)
if err != nil {
log.Warnf("Error attempting call to get SSH username: %s", err)
}
return username
}
func (c *RPCClientDriver) GetState() (state.State, error) {
var s state.State
if err := c.Client.Call(GetStateMethod, struct{}{}, &s); err != nil {
return state.Error, err
}
return s, nil
}
func (c *RPCClientDriver) PreCreateCheck() error {
return c.Client.Call(PreCreateCheckMethod, struct{}{}, nil)
}
func (c *RPCClientDriver) Create() error {
return c.Client.Call(CreateMethod, struct{}{}, nil)
}
func (c *RPCClientDriver) Remove() error {
return c.Client.Call(RemoveMethod, struct{}{}, nil)
}
func (c *RPCClientDriver) Start() error {
return c.Client.Call(StartMethod, struct{}{}, nil)
}
func (c *RPCClientDriver) Stop() error {
return c.Client.Call(StopMethod, struct{}{}, nil)
}
func (c *RPCClientDriver) Restart() error {
return c.Client.Call(RestartMethod, struct{}{}, nil)
}
func (c *RPCClientDriver) Kill() error {
return c.Client.Call(KillMethod, struct{}{}, nil)
}
func (c *RPCClientDriver) Upgrade() error {
return c.Client.Call(UpgradeMethod, struct{}{}, nil)
}