CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-20 18:56:39 +02:00
Code Issues Projects Releases Wiki Activity

(rm_1): Remove static' attribute on local status'.

Browse Source 
First off, the attribute should have been `volatile' (not static)
to avoid longjmp-related risk of clobber.  Secondly, now there is
no longer any risk of a local variable being clobbered, so there's
no need for any attribute at all.
This commit is contained in:
Jim Meyering
2006-01-06 10:14:19 +00:00
parent de0f11596d
commit 01ab0b79a1
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/remove.c
View File

@@ -1309,11 +1309,8 @@ rm_1 (Dirstack_state *ds, char const *filename,
AD_push_initial (ds);
AD_INIT_OTHER_MEMBERS ();
/* Put `status' in static storage, so it can't be clobbered
by the potential longjmp into this function. */
static enum RM_status status;
int fd_cwd = AT_FDCWD;
status = remove_entry (fd_cwd, ds, filename, x, NULL);
enum RM_status status = remove_entry (fd_cwd, ds, filename, x, NULL);
if (status == RM_NONEMPTY_DIR)
{
/* In the event that remove_dir->remove_cwd_entries detects