CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-02-16 04:12:26 +02:00
Code Issues Projects Releases Wiki Activity

copy: call extent_copy also when make_holes is false, ...

Browse Source 
so that we benefit from using extents also when reading a sparse
input file with --sparse=never.
* src/copy.c (copy_reg): Remove erroneous test of "make_holes"
so that we call extent_copy also when make_holes is false.
Otherwise, what's the point of that parameter?
This commit is contained in:
Jim Meyering
2011-01-22 12:36:03 +01:00
parent 8ecb0c76c3
commit 0497a86f70
1 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/copy.c
View File

@@ -868,23 +868,20 @@ copy_reg (char const *src_name, char const *dst_name,
#endif
}
if (make_holes)
{
bool require_normal_copy;
/* Perform efficient extent copy for sparse file, fall back to the
standard copy only if the initial extent scan fails. If the
'--sparse=never' option was specified, we writing all data but
use extent copy if available to efficiently read. */
if (extent_copy (source_desc, dest_desc, buf_size,
src_open_sb.st_size, make_holes,
src_name, dst_name, &require_normal_copy))
goto preserve_metadata;
bool require_normal_copy;
/* Perform efficient extent copy for sparse file, fall back to the
standard copy only if the initial extent scan fails. If the
'--sparse=never' option was specified, we writing all data but
use extent copy if available to efficiently read. */
if (extent_copy (source_desc, dest_desc, buf_size,
src_open_sb.st_size, make_holes,
src_name, dst_name, &require_normal_copy))
goto preserve_metadata;
if (! require_normal_copy)
{
return_val = false;
goto close_src_and_dst_desc;
}
if (! require_normal_copy)
{
return_val = false;
goto close_src_and_dst_desc;
}
/* If not making a sparse file, try to use a more-efficient