1
0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-11 06:34:40 +02:00

Avoid false-positive when testing via valgrind.

* tests/mv/atomic: Grep strace output for a more specific pattern
than just "unlink", since that got a false positive when testing
under valgrind: unlink("/tmp/valgrind_proc_9657_cmdline_A51E9991") = 0
* tests/mv/Makefile.am (TESTS_ENVIRONMENT): Define EGREP.
This commit is contained in:
Jim Meyering
2006-11-12 08:22:46 +01:00
parent 7c96936a04
commit 28c7ef509e
3 changed files with 10 additions and 1 deletions

View File

@@ -1,3 +1,11 @@
2006-11-12 Jim Meyering <jim@meyering.net>
Avoid false-positive when testing via valgrind.
* tests/mv/atomic: Grep strace output for a more specific pattern
than just "unlink", since that got a false positive when testing
under valgrind: unlink("/tmp/valgrind_proc_9657_cmdline_A51E9991") = 0
* tests/mv/Makefile.am (TESTS_ENVIRONMENT): Define EGREP.
2006-10-28 Jim Meyering <jim@meyering.net>
* Makefile.maint (patch-check): Make it easier to regenerate

View File

@@ -46,5 +46,6 @@ TESTS = \
EXTRA_DIST = $(TESTS) vfat
TESTS_ENVIRONMENT = \
PERL="$(PERL)" \
EGREP="$(EGREP)" \
PATH="$(VG_PATH_PREFIX)`pwd`/../../src$(PATH_SEPARATOR)$$PATH" \
PROG=mv

View File

@@ -58,7 +58,7 @@ fi
fail=0
strace -qe unlink mv -T s1 s2 > out 2>&1 || fail=1
grep unlink out && fail=1
$EGREP 'unlink.*"s1"' out && fail=1
# Ensure that the source, s1, is gone.
ls -dl s1 > /dev/null 2>&1 && fail=1