CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-20 18:56:39 +02:00
Code Issues Projects Releases Wiki Activity

tests: avoid spurious failures due to insecure directory in PATH

Browse Source 
These tests perform no PATH search, and used to simply delete PATH from
the environment.  However, that is not portable, as seen on Cygwin,
where cygwin.dll must be resolvable via PATH when starting a sub-shell.
With commit 0cc04241, we took the alternate approach of untainting the
incoming $ENV{PATH}, but that fails when it contains an other-writable
directory.  Instead, now we hard code it to '/bin:/usr/bin'.

* tests/misc/pwd-long: Hard code $ENV{PATH} to a safe value.
* tests/rm/fail-eperm: Likewise.
Reported by Gilles Espinasse, Andreas Schwab, and Bauke Jan Douma.
This commit is contained in:
Jim Meyering
2009-11-19 10:13:22 +01:00
parent f18eef3284
commit 30eb606ed5
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/misc/pwd-long
View File

@@ -56,11 +56,11 @@ sub normalize_to_cwd_relative ($$$)
# Set up a safe, well-known environment
delete @ENV{qw(BASH_ENV CDPATH ENV)};
$ENV{IFS} = '';
# PATH is tricky - we can't just clear it, or cygwin will fail. But we
# can't use it as-is, or taint checking in `` will stop us. For this
# script, it is enough to scrub the incoming $PATH first.
$ENV{'PATH'} =~ /(.*)/;
$ENV{'PATH'} = "$1";
# Taint checking requires a sanitized $PATH. This script performs no $PATH
# search, so on most Unix-based systems, it is fine simply to clear $ENV{PATH}.
# However, on Cygwin, it's used to find cygwin.dll, so set it.
$ENV{PATH} = '/bin:/usr/bin';
# Save CWD's device and inode numbers.
my ($dev, $ino) = (stat '.')[0, 1];

10
tests/rm/fail-eperm
View File

@@ -34,11 +34,11 @@ $ENV{LC_ALL} = 'C';
# Set up a safe, well-known environment
delete @ENV{qw(BASH_ENV CDPATH ENV)};
$ENV{IFS} = '';
# PATH is tricky - we can't just clear it, or cygwin will fail. But we
# can't use it as-is, or taint checking in `` will stop us. For this
# script, it is enough to scrub the incoming $PATH first.
$ENV{'PATH'} =~ /(.*)/;
$ENV{'PATH'} = "$1";
# Taint checking requires a sanitized $PATH. This script performs no $PATH
# search, so on most Unix-based systems, it is fine simply to clear $ENV{PATH}.
# However, on Cygwin, it's used to find cygwin.dll, so set it.
$ENV{PATH} = '/bin:/usr/bin';
my @dir_list = qw(/tmp /var/tmp /usr/tmp);
my $rm = "$ENV{abs_top_builddir}/src/rm";