CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-20 18:56:39 +02:00
Code Issues Projects Releases Wiki Activity

tail: add comments noting potential inotify-related problems

Browse Source 
* src/tail.c (tail_forever_inotify): Add two FIXME comments.
This commit is contained in:
Jim Meyering
2009-06-29 20:43:26 +02:00
parent 5718733510
commit 6d0d1c47b2
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/tail.c
View File

@@ -1258,6 +1258,8 @@ tail_forever_inotify (int wd, struct File_spec *f, int n_files)
len = safe_read (wd, evbuf, evlen);
evbuf_off = 0;
/* For kernels prior to 2.6.21, read returns 0 when the buffer
is too small. FIXME: handle that. */
if (len == SAFE_READ_ERROR && errno == EINVAL && max_realloc--)
{
len = 0;
@@ -1277,8 +1279,10 @@ tail_forever_inotify (int wd, struct File_spec *f, int n_files)
{
for (i = 0; i < n_files; i++)
{
if (f[i].parent_wd == ev->wd &&
STREQ (ev->name, f[i].name + f[i].basename_start))
/* With N=hundreds of frequently-changing files, this O(N^2)
process might be a problem. FIXME: use a hash table? */
if (f[i].parent_wd == ev->wd
&& STREQ (ev->name, f[i].name + f[i].basename_start))
break;
}