1
0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-08-06 00:29:44 +02:00

copy: attempt copy offload with sparse files by default

This was seen to vastly improve performance
on NFS 4.2 systems by allowing server side copies,
with partially sparse files (avidemux generated mp4 files).

* src/copy.c (lseek_copy): Also set hole_size to 0,
i.e. enable copy_file_range(), with --sparse=auto (the default),
to enable copy offload in this case, as we've strong signal
from SEEK_DATA that we're operating on actual data and not holes here.
* NEWS: Mention the improvement.
Fixes https://bugs.gnu.org/60416
This commit is contained in:
Pádraig Brady
2022-12-30 19:34:27 +00:00
parent 266b7cbc84
commit 879d2180d6
2 changed files with 8 additions and 2 deletions
+6
View File
@@ -69,6 +69,12 @@ GNU coreutils NEWS -*- outline -*-
** Improvements
cp --sparse=auto (the default), mv, and install,
will use the copy_file_range syscall now also with sparse files.
This may be more efficient, by avoiding user space copies,
and possibly employing copy offloading or reflinking,
for the non sparse portion of such sparse files.
date --debug now diagnoses if multiple --date or --set options are
specified, as only the last specified is significant in that case.
+2 -2
View File
@@ -526,12 +526,12 @@ lseek_copy (int src_fd, int dest_fd, char **abuf, size_t buf_size,
last_ext_len = ext_len;
/* Copy this extent, looking for further opportunities to not
bother to write zeros unless --sparse=never, since SEEK_HOLE
bother to write zeros if --sparse=always, since SEEK_HOLE
is conservative and may miss some holes. */
off_t n_read;
bool read_hole;
if ( ! sparse_copy (src_fd, dest_fd, abuf, buf_size,
sparse_mode == SPARSE_NEVER ? 0 : hole_size,
sparse_mode != SPARSE_ALWAYS ? 0 : hole_size,
true, allow_reflink, src_name, dst_name,
ext_len, &n_read, &read_hole))
return false;