1
0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-02-13 10:52:09 +02:00

fmt: promptly diagnose write errors

* NEWS: Mention the improvement.
* src/fmt.c (put_line): Exit if any error writing line.
(flush_paragraph): Exit if any error writing buffer.
* tests/misc/write-errors.sh: Enable the (flush_paragraph) test case,
and add another to check the put_line() case.
This commit is contained in:
Pádraig Brady
2025-10-22 16:11:53 +01:00
parent 5971f450b5
commit c12a2ecb53
3 changed files with 12 additions and 2 deletions

3
NEWS
View File

@@ -43,6 +43,9 @@ GNU coreutils NEWS -*- outline -*-
** Improvements
'fmt' will now exit promptly upon receiving a write error,
which is significant when reading large / unbounded inputs.
'install' now uses posix_spawn() to invoke the strip program more efficiently.
'numfmt':

View File

@@ -810,7 +810,10 @@ flush_paragraph (void)
if (word_limit == word)
{
fwrite (parabuf, sizeof *parabuf, wptr - parabuf, stdout);
size_t to_write = wptr - parabuf;
if (fwrite (parabuf, 1, to_write, stdout) != to_write)
write_error ();
wptr = parabuf;
return;
}
@@ -1010,6 +1013,9 @@ put_line (WORD *w, int indent)
put_word (w);
last_line_length = out_column;
putchar ('\n');
if (ferror (stdout))
write_error ();
}
/* Output to stdout the word W. */

View File

@@ -33,7 +33,8 @@ cut -z -f1- /dev/zero
dd if=/dev/zero
expand /dev/zero
factor --version; yes 1 | factor
# TODO: fmt /dev/zero
fmt /dev/zero
fmt --version; yes | fmt
fold /dev/zero
fold -b /dev/zero
fold -c /dev/zero