CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-20 18:56:39 +02:00
Code Issues Projects Releases Wiki Activity

install: avoid warning with Solaris 10 cc

Browse Source 
* src/install.c (extra_mode): Don't assign ~S_IRWXUGO & ~S_IFMT
to a mode_t variable, as the number might be too big to fit.
Solaris 10 cc warns about this, and the C standard says it
has undefined behavior.
This commit is contained in:
Paul Eggert
2010-10-13 20:44:12 -07:00
parent 4015f93d30
commit c586bff1c0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/install.c
View File

@@ -186,8 +186,8 @@ have_same_content (int a_fd, int b_fd)
static bool
extra_mode (mode_t input)
{
const mode_t mask = ~S_IRWXUGO & ~S_IFMT;
return !! (input & mask);
mode_t mask = S_IRWXUGO | S_IFMT;
return !! (input & ~ mask);
}
/* Return true if copy of file SRC_NAME to file DEST_NAME is necessary. */