CC-tea/coreutils
1
0
Fork 0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-04-21 03:12:48 +02:00
Code Issues Projects Releases Wiki Activity

Don't include "quote.h" when it is not used.

Browse Source 
* src/md5sum.c: Remove unnecessary inclusion of "quote.h".
* src/expr.c: Likewise.
* src/shred.c: Likewise.
* Makefile.maint (sc_prohibit_quote_without_use): New rule.
* src/c99-to-c89.diff: Adjust offsets.
This commit is contained in:
Jim Meyering
2007-06-15 15:44:15 +02:00
parent 6a0dea3ca0
commit cad884a245
6 changed files with 25 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@@ -1,3 +1,12 @@
2007-06-15 Jim Meyering <jim@meyering.net>
Don't include "quote.h" when it is not used.
* src/md5sum.c: Remove unnecessary inclusion of "quote.h".
* src/expr.c: Likewise.
* src/shred.c: Likewise.
* Makefile.maint (sc_prohibit_quote_without_use): New rule.
* src/c99-to-c89.diff: Adjust offsets.
2007-06-14 Paul Eggert <eggert@cs.ucla.edu>
Clarify what "cat" documentation means by "blank" lines.

12
Makefile.maint
View File

@@ -179,6 +179,18 @@ sc_prohibit_quotearg_without_use:
else :; \
fi
# Don't include quote.h unless you use one of its functions.
sc_prohibit_quote_without_use:
@if $(CVS_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then \
files=$$(grep -l '# *include "quote\.h"' \
$$($(CVS_LIST_EXCEPT) | grep '\.c$$')) && \
grep -LE '\<quote(_n)? \(' $$files \
| grep . && \
{ echo "$(ME): the above files include "quote.h" but don't use it" \
1>&2; exit 1; } || :; \
else :; \
fi
sc_obsolete_symbols:
@grep -nE '\<(HAVE''_FCNTL_H|O''_NDELAY)\>' \
$$($(CVS_LIST_EXCEPT)) && \

2
src/c99-to-c89.diff
View File

@@ -106,7 +106,7 @@ retrieving revision 1.130
diff -u -p -r1.130 shred.c
--- a/src/shred.c 3 Sep 2006 02:53:16 -0000 1.130
+++ b/src/shred.c 3 Oct 2006 13:48:24 -0000
@@ -464,7 +464,7 @@ dopass (int fd, char const *qname, off_t
@@ -463,7 +463,7 @@ dopass (int fd, char const *qname, off_t
out. Thus, it shouldn't give up on bad blocks. This
code works because lim is always a multiple of
SECTOR_SIZE, except at the end. */

3
src/expr.c
View File

@@ -1,5 +1,5 @@
/* expr -- evaluate expressions.
Copyright (C) 86, 1991-1997, 1999-2006 Free Software Foundation, Inc.
Copyright (C) 86, 1991-1997, 1999-2007 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -37,7 +37,6 @@
#include "long-options.h"
#include "error.h"
#include "inttostr.h"
#include "quote.h"
#include "quotearg.h"
#include "strnumcmp.h"
#include "xstrtol.h"

3
src/md5sum.c
View File

@@ -1,5 +1,5 @@
/* Compute MD5, SHA1, SHA224, SHA256, SHA384 or SHA512 checksum of files or strings
Copyright (C) 1995-2006 Free Software Foundation, Inc.
Copyright (C) 1995-2007 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -38,7 +38,6 @@
#endif
#include "getline.h"
#include "error.h"
#include "quote.h"
#include "stdio--.h"
/* The official name of this program (e.g., no `g' prefix). */

3
src/shred.c
View File

@@ -1,6 +1,6 @@
/* shred.c - overwrite files and devices to make it harder to recover data
Copyright (C) 1999-2006 Free Software Foundation, Inc.
Copyright (C) 1999-2007 Free Software Foundation, Inc.
Copyright (C) 1997, 1998, 1999 Colin Plumb.
This program is free software; you can redistribute it and/or modify
@@ -101,7 +101,6 @@
#include "human.h"
#include "inttostr.h"
#include "quotearg.h" /* For quotearg_colon */
#include "quote.h" /* For quotearg_colon */
#include "randint.h"
#include "randread.h"