1
0
mirror of git://git.sv.gnu.org/coreutils.git synced 2026-07-26 10:39:01 +02:00

tests: avoid intermittent ulimit -v failures

* init.cfg (get_min_ulimit_v_): Increase the determined
virtual memory limit for the command by a page size
to avoid alignment issues causing false failures for
subsequent runs.
* tests/misc/cut-huge-range.sh: Be defensive and match
the cut invocations under test, more closely with the
form used to determine the VM memory limit.

This was noticed on i686 linux at:
http://hydra.nixos.org/build/28990456
This commit is contained in:
Pádraig Brady
2015-12-16 02:07:56 +00:00
parent 896006bf76
commit cd6e49ced8
2 changed files with 18 additions and 8 deletions
+14 -4
View File
@@ -158,14 +158,24 @@ require_openat_support_()
# Return 0 in case of success, and a non-Zero value otherwise.
get_min_ulimit_v_()
{
local vm
local v
local page_size
# Increase result by this amount to avoid alignment issues
page_size=$(getconf PAGESIZE || echo 4096)
page_size=$(($page_size / 1024))
for v in $( seq 5000 5000 50000 ); do
if ( ulimit -v $v && "$@" ) >/dev/null; then
local vm_prev
local prev_v
prev_v=$v
for v in $( seq $(($prev_v-1000)) -1000 1000 ); do
( ulimit -v $v && "$@" ) >/dev/null \
|| { echo $prev_v; return 0; }
( ulimit -v $v && "$@" ) >/dev/null || \
{
ret_v=$((prev_v + $page_size))
echo $ret_v
return 0
}
prev_v=$v
done
fi
+4 -4
View File
@@ -51,15 +51,15 @@ CUT_MAX=$(echo $SIZE_MAX | sed "$subtract_one")
# From coreutils-8.10 through 8.20, this would make cut try to allocate
# a 256MiB bit vector.
(ulimit -v $vm && : | cut -b$CUT_MAX- > err 2>&1) || fail=1
(ulimit -v $vm && cut -b$CUT_MAX- /dev/null > err 2>&1) || fail=1
# Up to and including coreutils-8.21, cut would allocate possibly needed
# memory upfront. Subsequently extra memory is no longer needed.
(ulimit -v $vm && : | cut -b1-$CUT_MAX >> err 2>&1) || fail=1
(ulimit -v $vm && cut -b1-$CUT_MAX /dev/null >> err 2>&1) || fail=1
# Explicitly disallow values above CUT_MAX
(ulimit -v $vm && : | returns_ 1 cut -b$SIZE_MAX 2>/dev/null) || fail=1
(ulimit -v $vm && : | returns_ 1 cut -b$SIZE_OFLOW 2>/dev/null) || fail=1
(ulimit -v $vm && returns_ 1 cut -b$SIZE_MAX /dev/null 2>/dev/null) || fail=1
(ulimit -v $vm && returns_ 1 cut -b$SIZE_OFLOW /dev/null 2>/dev/null) || fail=1
compare /dev/null err || fail=1