This complements the fix in 705865fa by adding a test for unset flags
with defaults as well as other combinations of set and unset flags.
Signed-off-by: John Sirois <john.sirois@gmail.com>
Previously StringSlice flag defaults were not respected. These use
special handling and that handling did not take account of default
values, always over-writing them. Expand the CommandLine interface to
take advantage of the underlying codegansta/cli.Context IsSet method and
guard default string slice overwrites with an IsSet test.
Signed-off-by: John Sirois <john.sirois@gmail.com>
In some cases, (e.g. private key not accessible or has incorrect
permissions) docker-machine failed with error "Something went wrong
running an SSH command!". This commit will add the correct debug
messages and show the correct errors for the bad private keys.
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
Updated `netstat` command to minimize its output with `-t` and `-l`
flags.
Refactored regex on `libmachine/provision/utils.go`:`checkDaemonUp` to
avoid `matchNetstatOut` returning `true` when remote machine has a
similar port to dockerPort listening (e.g. dockerPort := 2376 and
remote machine has port 23760 listening).
Refactored `utils_test.go` with more accurate `netstat` output.
Signed-off-by: Tiago Pires <tandrepires@gmail.com>
The egoscale binding for exoscale was limiting the images that could be
selected by a user to Ubuntu one only. Enable the use of arbitrary
images. For example, the following images are now available:
- centos-6.6
- centos-7.1
- coreos-stable-835
- debian-7
- debian-8
- ubuntu-12.04
- ubuntu-14.04
- ubuntu-15.10
The default user for non-Ubuntu images are not "ubuntu". Let the user
choose the appropriate user ("core" for CoreOS and "debian" for Debian).
CoreOS user are likely to want the ability to provide custom user data
as it enables the configuration of the etcd cluster. We add an option to
provide custom user data file. Moreover, we remove some of the default
options as they are not supported in CoreOS and are useless on
Debian/Ubuntu:
- Resizing of rootfs is already done on all images by default.
- Docker Machine will set the hostname as part of the provisioning.
Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>
This flag creates Azure VMs with static public IPs that don’t
get released when the VM is deallocated.
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
Added flag `--generic-engine-port` to `generic` drive in order to specify other port than `2376` on
Docker engine.
Updated `generic` driver documentation.
Signed-off-by: Tiago Pires <tandrepires@gmail.com>
Victoria Bialas
Nathan LeClaire
John Sirois
Maksim Malchuk
Tiago Pires
Andre Caron
Nathan LeClaire
Ahmet Alp Balkan
Vincent Bernat
David Gageot
James Nord
Matt Martz
Kazuhiro NISHIYAMA
Pradeep Padala
Troy Fontaine
bingshen.wbs
Stefan Scherer
Jie Zhang
Jacob Blain Christen