Add an empty string check to the path argument of addFile(). Send()
method of BugsnagCrashReporter calls addFile() passing err.LogFilePath
as the path argument, which is an empty string if the driver is not
virtualbox.
Fixes#3559
Signed-off-by: KOBAYASHI Shinji <koba@jp.fujitsu.com>
This modification permits the swarm-agent created by docker-machine to
take into account the —swarm-opt arguments.
Signed-off-by: Lucien Gougerot <lucien.gougerot@gmail.com>
When a passphrase protected key is not yet in ssh-agent, it gives a
chance to the user to fill a prompt instead of silently failing.
Signed-off-by: Bilal Amarni <bilal.amarni@gmail.com>
In some cases, (e.g. private key not accessible or has incorrect
permissions) docker-machine failed with error "Something went wrong
running an SSH command!". This commit will add the correct debug
messages and show the correct errors for the bad private keys.
Also, due to incorrect handling POSIX file permissions in Windows
some checks should be ignored.
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
Using the user-defined ssh_config configurations bring more problems
instead of enchancements.
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
Fixes#1361Fixes#3164
Corrected copy/paste typo in libmachine/provision/fedora_test.go
Preserve environment when performing yum update for proxy settings.
Signed-off-by: Eric A. Zarko <eric.zarko@oracle.com>
In some cases, (e.g. private key not accessible or has incorrect
permissions) docker-machine failed with error "Something went wrong
running an SSH command!". This commit will add the correct debug
messages and show the correct errors for the bad private keys.
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
Updated `netstat` command to minimize its output with `-t` and `-l`
flags.
Refactored regex on `libmachine/provision/utils.go`:`checkDaemonUp` to
avoid `matchNetstatOut` returning `true` when remote machine has a
similar port to dockerPort listening (e.g. dockerPort := 2376 and
remote machine has port 23760 listening).
Refactored `utils_test.go` with more accurate `netstat` output.
Signed-off-by: Tiago Pires <tandrepires@gmail.com>
Added flag `--generic-engine-port` to `generic` drive in order to specify other port than `2376` on
Docker engine.
Updated `generic` driver documentation.
Signed-off-by: Tiago Pires <tandrepires@gmail.com>
The new driver uses Azure Resource Manager APIs and offers a lot
more functionality compared to the old Azure driver. It is also
easier to authenticate and does not require user to create and place
certificate files. It only has a single required argument.
This is a breaking change: The new driver cannot work with machines
created with the older Azure driver and vice versa (as the APIs are
entirely different and resources are not shared between old/new azure
APIs).
The new driver addresses many issues about the azure driver reported
so far.
This resolves#2742, resolves#1368, resolves#1142, resolves#2236,
resolves#2408, resolves#1126, resolves#774.
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
This commit temporarily removes Azure driver and its dependencies
from the source tree and adds dependencies for the new Azure driver
(so that Azure driver PR will not have godeps changes and will be
easier to review).
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
The `create` command now has the `--swarm-experimental` boolean flag, that
tells the Swarm provisioner to enable experimental features in Swarm.
Fixes#2861
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
